Update Rollup, Jest, Typescript, EsLint

1. Newer tools are better 2. Required to support native-NodeJS fetch in Jest (for FiatApi tests)
nimiq · Jan 25, 2024 · 34ea200 · 34ea200
1 parent 69d2d16
commit 34ea200
Show file tree

Hide file tree

Showing 10 changed files with 2,851 additions and 3,022 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -48,5 +48,11 @@ module.exports = {
         'no-param-reassign': 'off',
         'import/no-unresolved': 'off',
         'no-use-before-define': 'off',
+        'no-shadow': 'off',
+        'no-dupe-class-members': 'off',
+        'no-undef': 'off',
+
+        // Allow importing TS files without extension, as Rollup takes care of that
+        'import/extensions': 'off',
     },
 };
diff --git a/jest.config.js b/jest.config.js
@@ -1,4 +1,7 @@
-module.exports = {
+/** @type {import('jest').Config} */
+const config = {
   preset: 'ts-jest',
   testEnvironment: 'jsdom',
 };
+
+module.exports = config;
diff --git a/package.json b/package.json
@@ -23,16 +23,17 @@
     "big-integer": "^1.6.44"
   },
   "devDependencies": {
-    "@types/jest": "^24.0.23",
-    "@typescript-eslint/eslint-plugin": "^2.7.0",
-    "@typescript-eslint/parser": "^2.7.0",
-    "eslint": "^6.6.0",
-    "eslint-config-airbnb-base": "^14.0.0",
-    "eslint-plugin-import": "^2.18.2",
-    "jest": "^24.9.0",
+    "@types/jest": "^29.5.11",
+    "@typescript-eslint/eslint-plugin": "^6.19.1",
+    "@typescript-eslint/parser": "^6.19.1",
+    "eslint": "^8.56.0",
+    "eslint-config-airbnb-base": "^15.0.0",
+    "eslint-plugin-import": "^2.29.1",
+    "jest": "^29.7.0",
+    "jest-environment-jsdom": "^29.7.0",
     "rimraf": "^2.6.3",
-    "rollup": "^0.64.0",
-    "ts-jest": "^24.1.0",
-    "typescript": "^3.2.0"
+    "rollup": "^4.9.6",
+    "ts-jest": "^29.1.2",
+    "typescript": "^4.3.0"
   }
 }
diff --git a/rollup.config.js → rollup.config.mjs b/rollup.config.js → rollup.config.mjs
@@ -27,5 +27,4 @@ export default {
             sourcemap: true
         }
     ],
-    experimentalCodeSplitting: true
 };
diff --git a/src/currency-info/CurrencyInfo.ts b/src/currency-info/CurrencyInfo.ts
@@ -274,7 +274,7 @@ export class CurrencyInfo {
     public readonly decimals!: number;
     public readonly locale: string;
 
-    /* eslint-disable no-dupe-class-members, lines-between-class-members */
+    /* eslint-disable lines-between-class-members */
     /**
      * This constructor is convenient when manually defining a CurrencyInfo or when no locale is to be specified.
      * @constructor
@@ -359,7 +359,7 @@ export class CurrencyInfo {
         const cacheKey = `${this.code} ${this.locale}`;
         const cachedCurrencyInfo = CurrencyInfo.CACHED_AUTO_GENERATED_CURRENCY_INFOS[cacheKey];
         if (isAutoGenerated && cachedCurrencyInfo) {
-            return cachedCurrencyInfo;
+            return cachedCurrencyInfo; // eslint-disable-line no-constructor-return
         }
 
         let formattedString;
@@ -460,5 +460,5 @@ export class CurrencyInfo {
             CurrencyInfo.CACHED_AUTO_GENERATED_CURRENCY_INFOS[cacheKey] = this;
         }
     }
-    /* eslint-enable no-dupe-class-members, lines-between-class-members */
+    /* eslint-enable lines-between-class-members */
 }
diff --git a/src/fiat-api/FiatApi.ts b/src/fiat-api/FiatApi.ts
@@ -278,7 +278,7 @@ async function _fetch(input: RequestInfo, init?: RequestInit): Promise<any> {
             // be resolved in random order.
             if (retry) {
                 // eslint-disable-next-line no-await-in-loop
-                await new Promise((resolve) => setTimeout(resolve, 15000));
+                await new Promise((resolve) => { setTimeout(resolve, 15000); });
             } else {
                 throw e;
             }

diff --git a/src/request-link-encoding/RequestLinkEncoding.ts b/src/request-link-encoding/RequestLinkEncoding.ts
@@ -551,7 +551,7 @@ function parseUnsignedInteger(value: string): number | bigint {
         // Non-integer, non-safe integer larger than Number.MAX_SAFE_INTEGER or NaN (which it can't really be as
         // toNonScientificNumberString parses only valid numbers). Try parsing again as bigint, which supports integers
         // above Number.MAX_SAFE_INTEGER, and throws for actual invalid or non-integer numbers.
-        result = BigInt(value); // eslint-disable-line no-undef
+        result = BigInt(value);
     }
     return result;
 }

diff --git a/src/utf8-tools/Utf8Tools.ts b/src/utf8-tools/Utf8Tools.ts
@@ -209,7 +209,7 @@ export class Utf8Tools {
         return i === bytes.length;
     }
 
-    /* eslint-disable lines-between-class-members, no-dupe-class-members */
+    /* eslint-disable lines-between-class-members */
     public static truncateToUtf8ByteLength(input: string, length: number, applyEllipsis?: boolean)
         : { result: string, didTruncate: boolean };
     public static truncateToUtf8ByteLength(input: Uint8Array, length: number, applyEllipsis?: boolean)
@@ -257,5 +257,5 @@ export class Utf8Tools {
             didTruncate: true,
         };
     }
-    /* eslint-enable lines-between-class-members, no-dupe-class-members */
+    /* eslint-enable lines-between-class-members */
 }
diff --git a/tsconfig.json b/tsconfig.json
@@ -4,8 +4,6 @@
     "target": "esnext",
     "module": "esnext",
     "strict": true,
-    "jsx": "preserve",
-    "importHelpers": true,
     "moduleResolution": "node",
     "experimentalDecorators": true,
     "esModuleInterop": true,
@@ -20,7 +18,8 @@
       "dom",
       "dom.iterable",
       "scripthost"
-    ]
+    ],
+    "skipLibCheck": true,
   },
   "include": [
     "src/**/*.ts",
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,5 +27,4 @@ export default { @@
                 sourcemap: true
             }
         ],
-        experimentalCodeSplitting: true
     };