Validator health status #3207
Open
Validator health status #3207
+351
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viquezclaudio
force-pushed
the
viquezcl/validator
branch
2 times, most recently
from
f08b8d3 to
8108a5b
Compare
Track the number of blocks that are succesfully produced when changing the validator health
viquezclaudio
force-pushed
the
viquezcl/validator
branch
from
6978477 to
124258f
Compare
Eligioo
reviewed
Jan 9, 2025
| @@ -113,7 +113,7 @@ where | |||
| let (v, c) = build_validator( | |||
| peer_ids[i], | |||
| Address::from(&validator_keys[i]), | |||
| false, | |||
| true, | |||
There was a problem hiding this comment.
Make automatic_reactivate a fn param for build_validators so it doesn't influence other tests?
validator/src/validator.rs
Outdated
| /// The current validator health | ||
| pub health: ValidatorHealth, | ||
| /// Number of blocks that we have produced in time(without being inactivated) | ||
| pub blk_cnt: u32, |
There was a problem hiding this comment.
Suggested change
| pub blk_cnt: u32, | |
| pub block_counter: u32, |
validator/src/micro.rs
Outdated
| @@ -181,6 +198,8 @@ impl<TValidatorNetwork: ValidatorNetwork + 'static> NextProduceMicroBlockEvent<T | |||
| continue; | |||
| } | |||
|
|
|||
| self.health_state.write().blk_cnt += 1; | |||
There was a problem hiding this comment.
Suggested change
| self.health_state.write().blk_cnt += 1; | |
| self.health_state.write().blk_cnt.saturating_add(1); |
Prevent overflow
Comment on lines
+168
to
+170
| log::warn!(block = block.block_number(), "Not publishing block"); | ||
| let event = ProduceMicroBlockEvent::MicroBlock; | ||
| break Some(Some(event)); |
There was a problem hiding this comment.
Suggested change
| log::warn!(block = block.block_number(), "Not publishing block"); | |
| let event = ProduceMicroBlockEvent::MicroBlock; | |
| break Some(Some(event)); | |
| log::warn!(block = block.block_number(), "Not publishing block"); | |
| break Some(Some(ProduceMicroBlockEvent::MicroBlock)); |
| pub health: ValidatorHealth, | ||
| /// Number of blocks that we have produced in time(without being inactivated) | ||
| pub blk_cnt: u32, | ||
| /// For testing/debug purposes control wether produced blocks are published by the validator |
There was a problem hiding this comment.
Suggested change
| /// For testing/debug purposes control wether produced blocks are published by the validator | |
| /// For testing/debug purposes control whether produced blocks are published by the validator |
validator/src/validator.rs
Outdated
| pub struct HealthState { | ||
| /// The current validator health | ||
| pub health: ValidatorHealth, | ||
| /// Number of blocks that we have produced in time(without being inactivated) |
There was a problem hiding this comment.
Suggested change
| /// Number of blocks that we have produced in time(without being inactivated) | |
| /// Number of subsequent blocks that we have been produced without being inactivated |
validator/src/validator.rs
Outdated
| good_blocks = %self.health_state.read().blk_cnt, | ||
| "Current validator health is yellow", | ||
| ); | ||
| if self.health_state.read().blk_cnt >= VALIDATOR_HEALTH_THRESHOLD { |
There was a problem hiding this comment.
This logic doesn't seem to match with the original description: If the validator is Yellow and is not deactivated in a quarter of an epoch, we change its status to Green.
validator/src/validator.rs
Outdated
| inactivated = red_block_number, | ||
| "Current validator health is red", | ||
| ); | ||
| if self.health_state.read().blk_cnt >= VALIDATOR_HEALTH_THRESHOLD { |
There was a problem hiding this comment.
This logic doesn't seem to match with the original description: If the validator is Red and is not deactivated in one epoch, we change its status to Yellow.
validator/src/validator.rs
Outdated
Comment on lines
927
to
928
| let validator_health = self.health_state.read().health; | ||
| match validator_health { |
There was a problem hiding this comment.
Suggested change
| let validator_health = self.health_state.read().health; | |
| match validator_health { | |
| match self.health_state.read().health { |
validator/src/validator.rs
Outdated
| } | ||
| ValidatorHealth::Red(_) => { | ||
| log::warn!( | ||
| "The validator needs human intervention, no automatic reactivate" |
There was a problem hiding this comment.
Suggested change
| "The validator needs human intervention, no automatic reactivate" | |
| "The validator needs human intervention, no automatic reactivation" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
...
This fixes #___.
Pull request checklist
clippyandrustfmtwarnings.