inline structural/alias invocations even with generic arguments, broken #335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In:
first
SemcheckTopLevelSyms
will save the untyped AST of the types to their symbols, however they will not define typevars or look them up in the body. This means whenNodeObj
is being semchecked, attempting to inlineNode[T]
by instantiating it will not work because there will be no typevars to replace.This is a general problem for forwarded generic types:
A solution might be to define the typevars in the
SemcheckTopLevelSyms
pass and use an untyped prepass on the body so that they can be instantiated. But this is not done yet as an untyped prepass is not implemented.The original reason for this PR was that the
Node[T]()
object constructor syntax/dotfields etc in generics don't work without it, but there is another solution which is just recursively skippingref
/invocations.