nifc: fixes top level var decls with non-literals #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Jan 2, 2025
src/nifc/codegen.nim
Outdated
| if vk != IsLocal: dec c.inSimpleInit | ||
| c.add Semicolon | ||
| if vk == IsGlobal and | ||
| t[d.value].kind notin {IntLit, UIntLit, FloatLit, CharLit, StrLit, FalseC, TrueC}: |
There was a problem hiding this comment.
But "bracket expressions" for arrays and objects are fine too and it would be wrong to move them!
Araq
reviewed
Jan 3, 2025
src/nifc/codegen.nim
Outdated
| if vk == IsGlobal and | ||
| t[d.value].kind notin {IntLit, UIntLit, FloatLit, | ||
| CharLit, StrLit, FalseC, TrueC, AconstrC, | ||
| OconstrC, InfC, NegInfC, NanC, SufC}: |
There was a problem hiding this comment.
You need some isLiteral deep check for OconstrC and AconstrC as [1, 2] is very different from [myVar, 3]. Thanks to NIF you can do this iteratively and no recursion is required.
There was a problem hiding this comment.
I have no clues how to deal with Tree iteratively. Do I need to use hasNext to query the end of the tree or something?
There was a problem hiding this comment.
You use the simple while n.kind != ParRi:... loop but your way is fine too. Also NIFC doesn't yet use the newer APIs so that's probably why you were confused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes top level var decls