Fixes #8100 #8101
Merged
Fixes #8100 #8101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could technically do |
dom96
reviewed
Jun 24, 2018
| @@ -258,7 +258,9 @@ template callFormat(res, arg) {.dirty.} = | |||
| # workaround in order to circumvent 'strutils.format' which matches | |||
| # too but doesn't adhere to our protocol. | |||
| res.add arg | |||
| elif compiles(format(arg, res)): | |||
| elif compiles(format(arg, res)) and | |||
There was a problem hiding this comment.
Maybe the following would be better?
elif compiles((var res = ""; format(arg, res)))Strange that the current code doesn't catch the "return value needs to be discarded" error. Maybe the above version will?
It's because I switched to the |
|
Travis hickup, closing and re-opening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked for a less hacky way to check if a proc returns void, but couldn't find any. Related: #7397