-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #20681; add efSkipFieldVisibilityCheck to skip check #20639
Conversation
It seems that there is probably nothing wrong with this patch. I have spent a bad time debugging the macros of loopfusion, I think these changes may work. With this patch, the type of Am I correct or do I miss something? |
wait for #20662 |
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
…im-lang#20639) * don't sem const objectConstr defaults * fixes * add `efSkipFieldVisibilityCheck`; fixes nkBracket types * fixes nim-lang#20681 * fixes tests * suggestion from @metagn * fixes tests Co-authored-by: xflywind <[email protected]>
…im-lang#20639) * don't sem const objectConstr defaults * fixes * add `efSkipFieldVisibilityCheck`; fixes nkBracket types * fixes nim-lang#20681 * fixes tests * suggestion from @metagn * fixes tests Co-authored-by: xflywind <[email protected]>
fixes #20681
Constant object construction has been checked and
inlined
already, there is no need tosem
it again, especially for default fields.fixes