Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong collision box scaling of physics props #410

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wjxggg
Copy link

@wjxggg wjxggg commented Jan 9, 2025

For example:
SetModelScale
Create a prop_physics entity with SetModelScale(2) then Activate()

Before the fix:
before

After the fix:
after

What is wrong:
SetCollisionBounds doesn't require scale information
It reads the scaling information directly from GetModelScale
Which is SetModelScale will do

@wjxggg
Copy link
Author

wjxggg commented Jan 11, 2025

CBaseAnimating::TestHitboxes always returns true, whether the ray hits or not
This has not yet caused problems
But compared to other similar functions, this is confusing
So I made it to return true if the ray hit, and false if not

@wjxggg
Copy link
Author

wjxggg commented Jan 11, 2025

And there is a mismatch issue on client side when a prop is scaled
I'm still working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant