Elastic-metadata-v1clean #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrethe
had a problem deploying
to
github-pages
GitHub Actions
Failure
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| self.connect() | ||
|
|
||
| def connect(self) -> str: | ||
| """ Not needed as metadata services are REST service calls """ |
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| """ Not needed as metadata services are REST service calls """ | |
| """Not needed as metadata services are REST service calls""" |
Comment on lines
118
to
119
| ##################################################################### | ||
| # Supporting Functions |
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| ##################################################################### | |
| # Supporting Functions | |
| ##################################################################### | |
| # Supporting Functions |
Comment on lines
121
to
122
| ##################################################################### | ||
| # Function to GET content from URL with retries |
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| ##################################################################### | |
| # Function to GET content from URL with retries | |
| ##################################################################### | |
| # Function to GET content from URL with retries |
| ##################################################################### | ||
| # Function to GET content from URL with retries | ||
| def getURL(self, url, headers="NONE"): | ||
|
|
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
Comment on lines
128
to
130
| retries = Retry(total=6, | ||
| backoff_factor=1, | ||
| status_forcelist=[403, 404, 413, 429, 500, 502, 503, 504]) |
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| retries = Retry(total=6, | |
| backoff_factor=1, | |
| status_forcelist=[403, 404, 413, 429, 500, 502, 503, 504]) | |
| retries = Retry( | |
| total=6, backoff_factor=1, status_forcelist=[403, 404, 413, 429, 500, 502, 503, 504] | |
| ) |
Comment on lines
230
to
234
| def list_datasets( | ||
| self, | ||
| limit: int = 10, | ||
| offset: int = 0 | ||
| ) -> list: |
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| def list_datasets( | |
| self, | |
| limit: int = 10, | |
| offset: int = 0 | |
| ) -> list: | |
| def list_datasets(self, limit: int = 10, offset: int = 0) -> list: |
| """ | ||
| self.host_api = "https://scicrunch.org/api/1/elastic/SPARC_Algolia_pr/_search" | ||
|
|
||
| list_url = self.host_api + "?" + "from=" + str(offset) + "&size=" + str(limit) + "&key=" + self.scicrunch_api_key |
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| list_url = self.host_api + "?" + "from=" + str(offset) + "&size=" + str(limit) + "&key=" + self.scicrunch_api_key | |
| list_url = ( | |
| self.host_api | |
| + "?" | |
| + "from=" | |
| + str(offset) | |
| + "&size=" | |
| + str(limit) | |
| + "&key=" | |
| + self.scicrunch_api_key | |
| ) |
| list_results = self.getURL(list_url, headers=self.default_headers) | ||
| return list_results | ||
|
|
||
|
|
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| def search_datasets(self, query: str = '{"query": { "match_all": {}}}') -> list: | |
| """Gets datasets matching specified query. | |
Comment on lines
257
to
263
| def search_datasets( | ||
| self, | ||
| query: str = "{\"query\": { \"match_all\": {}}}" | ||
| ) -> list: | ||
| """Gets datasets matching specified query. | ||
|
|
||
| This function provides |
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| def search_datasets( | |
| self, | |
| query: str = "{\"query\": { \"match_all\": {}}}" | |
| ) -> list: | |
| """Gets datasets matching specified query. | |
| This function provides | |
| This function provides |
|
|
||
| list_url = self.host_api + "?" + "key=" + self.scicrunch_api_key | ||
|
|
||
| list_results = self.postURL(list_url, body = query, headers=self.default_headers) |
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| list_results = self.postURL(list_url, body = query, headers=self.default_headers) | |
| list_results = self.postURL(list_url, body=query, headers=self.default_headers) |
| # Instructions for getting an API key can be found at: https://fdilab.gitbook.io/api-handbook/sparc-k-core-api-overview/getting-started-with-sparc-apis | ||
|
|
||
| import json | ||
| from sparc.client import SparcClient |
There was a problem hiding this comment.
[formatters] reported by reviewdog 🐶
Suggested change
| from sparc.client import SparcClient | |
| from sparc.client import SparcClient |
| @@ -0,0 +1,281 @@ | |||
| import logging | |||
There was a problem hiding this comment.
[formatters] reported by reviewdog 🐶
Suggested change
| import logging |
| @@ -0,0 +1,281 @@ | |||
| import logging | |||
| import json | |||
|
|
|||
There was a problem hiding this comment.
[formatters] reported by reviewdog 🐶
Suggested change
| import logging | |
| from configparser import SectionProxy | |
| from typing import List, Optional, Union | |
Comment on lines
7
to
8
| from configparser import SectionProxy | ||
| from typing import List, Optional, Union |
There was a problem hiding this comment.
[formatters] reported by reviewdog 🐶
Suggested change
| from configparser import SectionProxy | |
| from typing import List, Optional, Union |
| self.connect() | ||
|
|
||
| def connect(self) -> str: | ||
| """ Not needed as metadata services are REST service calls """ |
There was a problem hiding this comment.
[formatters] reported by reviewdog 🐶
Suggested change
| """ Not needed as metadata services are REST service calls """ | |
| """Not needed as metadata services are REST service calls""" |
Comment on lines
230
to
234
| def list_datasets( | ||
| self, | ||
| limit: int = 10, | ||
| offset: int = 0 | ||
| ) -> list: |
There was a problem hiding this comment.
[formatters] reported by reviewdog 🐶
Suggested change
| def list_datasets( | |
| self, | |
| limit: int = 10, | |
| offset: int = 0 | |
| ) -> list: | |
| def list_datasets(self, limit: int = 10, offset: int = 0) -> list: |
| """ | ||
| self.host_api = "https://scicrunch.org/api/1/elastic/SPARC_Algolia_pr/_search" | ||
|
|
||
| list_url = self.host_api + "?" + "from=" + str(offset) + "&size=" + str(limit) + "&key=" + self.scicrunch_api_key |
There was a problem hiding this comment.
[formatters] reported by reviewdog 🐶
Suggested change
| list_url = self.host_api + "?" + "from=" + str(offset) + "&size=" + str(limit) + "&key=" + self.scicrunch_api_key | |
| list_url = ( | |
| self.host_api | |
| + "?" | |
| + "from=" | |
| + str(offset) | |
| + "&size=" | |
| + str(limit) | |
| + "&key=" | |
| + self.scicrunch_api_key | |
| ) |
| list_results = self.getURL(list_url, headers=self.default_headers) | ||
| return list_results | ||
|
|
||
|
|
There was a problem hiding this comment.
[formatters] reported by reviewdog 🐶
Suggested change
| def search_datasets(self, query: str = '{"query": { "match_all": {}}}') -> list: | |
| """Gets datasets matching specified query. | |
Comment on lines
257
to
263
| def search_datasets( | ||
| self, | ||
| query: str = "{\"query\": { \"match_all\": {}}}" | ||
| ) -> list: | ||
| """Gets datasets matching specified query. | ||
|
|
||
| This function provides |
There was a problem hiding this comment.
[formatters] reported by reviewdog 🐶
Suggested change
| def search_datasets( | |
| self, | |
| query: str = "{\"query\": { \"match_all\": {}}}" | |
| ) -> list: | |
| """Gets datasets matching specified query. | |
| This function provides | |
| This function provides |
|
|
||
| list_url = self.host_api + "?" + "key=" + self.scicrunch_api_key | ||
|
|
||
| list_results = self.postURL(list_url, body = query, headers=self.default_headers) |
There was a problem hiding this comment.
[formatters] reported by reviewdog 🐶
Suggested change
| list_results = self.postURL(list_url, body = query, headers=self.default_headers) | |
| list_results = self.postURL(list_url, body=query, headers=self.default_headers) |
jgrethe
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean pull request with files changed or added only related to the metadata services