Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest linux build setup #16

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

latest linux build setup #16

wants to merge 3 commits into from

Conversation

tomsail
Copy link
Collaborator

@tomsail tomsail commented Mar 19, 2024

The main goal of this PR is have traceability of the setup I used to create multiple environments following the Python/Numpy compatibility table and also diverse versions of openMPI and mpich.

This could also be merged in a linux branch because it is specific to the creation of linux version of opentelemac on conda.

Stuff that need to be corrected/discussed :

  • the download from the main branch in meta.yaml and the 2 patches (global.patch and fix981.patch): I know this is not the correct way to do it.. but we need those implementations for our uses, so I couldn't for the next official tag release. Practically these patches contain the implementation that is in 3 open MRs: 178, 179 and 180 on the official telemac repo that are necessary for running global storm surge models with enhanced i/o processing times.
  • matrix_build.sh the script I used to build and upload my conda environment from my local machine.

For all of the reasons above, I have put this PR in draft. Ideally I will drop the patches in meta.yaml once the MR are merged in main, and then change to a tag once v8p6 or v8p5r1 gets released

Finally, there is also the fix for #15

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debian.systel.cfg from source could be used, isn't it ?
https://gitlab.pam-retd.fr/otm/telemac-mascaret/-/blob/main/configs/systel.debian.cfg?ref_type=heads
And set correct USETELCFG at compile time to avoid compiling all configs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet: I haven't managed to include MED. And I don't think we need to include it anyway.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A patch to remove MED from official systel ?

Comment on lines -24 to +38
- name: {{ name }}-examples
build:
script: "%RECIPE_DIR%/build-examples.bat" # [win]
script: "$RECIPE_DIR/build-examples.sh" # [not win]
## we only need to build exemples and docs once # # # # # # # #
# - name: {{ name }}-examples
# build:
# script: "%RECIPE_DIR%/build-examples.bat" # [win]
# script: "$RECIPE_DIR/build-examples.sh" # [not win]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove it completly

Comment on lines -29 to +44
- name: {{ name }}-documentation
build:
script: "%RECIPE_DIR%/build-documentation.bat" # [win]
script: "$RECIPE_DIR/build-documentation.sh" # [not win]
# - name: {{ name }}-documentation
# build:
# script: "%RECIPE_DIR%/build-documentation.bat" # [win]
# script: "$RECIPE_DIR/build-documentation.sh" # [not win]
## # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # #
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@@ -93,12 +105,9 @@ outputs:
# Python
- matplotlib
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace by matplotlib-base

export PYTHONPATH=$HOMETEL/builds/$USETELCFG/wrap_api/lib:$PYTHONPATH
export LD_LIBRARY_PATH=$HOMETEL/builds/$USETELCFG/wrap_api/lib:$HOMETEL/builds/$USETELCFG/lib:$CONDA_PREFIX/lib
export PYTHONUNBUFFERED='true'
export LD_LIBRARY_PATH=$HOMETEL/builds/$USETELCFG/wrap_api/lib:$HOMETEL/builds/$USETELCFG/lib:$LD_LIBRARY_PATH

telemac-debug() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants