Fix edge cases with swiftTesting rule #1968
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes edge cases I noticed with the new
swiftTesting
rule that would cause build failures or runtime issues. For example:@Suite(.serialized)
by default to match the XCTest behavior where tests run serially by default. Existing tests may not expect to be ran concurrently. I saw issues related to this in Airbnb's test suite.import Foundation
by default, since XCTest exportsFoundation
(common for test cases to rely on Foundation types)import UIKit
if the file uses any UIKit symbols (common in tests for app codebases) since XCTest exports UIKit!foo == bar
,!foo is Bar
,try? foo == bar
, etc. (should be (!(foo == bar)
,!(foo is Bar)
,(try? foo) == bar
).With these fixes, Airbnb's unit test suite builds, runs, and passes successfully after applying the
swiftTesting
rule (after also manually fixing a relatively reasonable number of more minor edge cases).