Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export map to package #37

Merged
merged 1 commit into from
Mar 20, 2022
Merged

Add export map to package #37

merged 1 commit into from
Mar 20, 2022

Conversation

nickbabcock
Copy link
Owner

@nickbabcock nickbabcock commented Mar 4, 2022

Following the guidelines here: https://nodejs.org/api/packages.html#package-entry-points

We now score 100% on skypack quality: https://docs.skypack.dev/package-authors/package-checks

This shouldn't have a visible impact except for node js users who
install with --no-addons, which will cause them to receive the Wasm
hasher by default.

Needed to sub jest out for vitest due to jestjs/jest#12574

Needed to sub out for our own wasm plugin due to rollup/plugins#1129

Created a /slim package entrypoint for browser developers that don't want (or can't have) the Wasm base64 inlined.

@nickbabcock nickbabcock force-pushed the export-map branch 2 times, most recently from 9187777 to a846614 Compare March 12, 2022 15:52
Following the guidelines here: https://nodejs.org/api/packages.html#package-entry-points

We now score 100% on skypack quality: https://docs.skypack.dev/package-authors/package-checks

This shouldn't have a visible impact except for node js users who
install with `--no-addons`, which will cause them to receive the Wasm
hasher by default.
@nickbabcock nickbabcock merged commit b60eaf4 into master Mar 20, 2022
@nickbabcock nickbabcock deleted the export-map branch March 20, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant