Capture additional components in prometheus sample dashboard #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When querying the breakdown of hardware components, the prometheus query may
be too narrow and exclude components that didn't match but should have been
included. For instance the previous hardware query:
```
ohm_hdd_load_percent{instance="$instance"}
```
Will exclude hard drives without load percentages.
The fix is to match on name prefix, so anything that starts with `ohm_hdd_` is
considered a harddrive and will have its own details section.
Grafana version was updated in the meantime, as there are still some
UI oddities in the dashboard remaining, which may be fixed in a future
update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying the breakdown of hardware components, the prometheus query may
be too narrow and exclude components that didn't match but should have been
included. For instance the previous hardware query:
Will exclude hard drives without load percentages.
The fix is to match on name prefix, so anything that starts with
ohm_hdd_isconsidered a harddrive and will have its own details section.
Grafana version was updated in the meantime, as there are still some
UI oddities in the dashboard remaining, which may be fixed in a future
update
Addresses part of #246 (comment)