Updated deprecated PHP construction and removed PHP 5 compatibility c…

…ode/comments
nibou230 · Jan 8, 2022 · ff78374 · ff78374
1 parent 5073663
commit ff78374
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 20 deletions.
diff --git a/classes/install/Install.inc.php b/classes/install/Install.inc.php
@@ -23,10 +23,6 @@
 
 use PKP\install\PKPInstall;
 
-// Default installation data
-define('INSTALLER_DEFAULT_SITE_TITLE', 'common.software');
-define('INSTALLER_DEFAULT_MIN_PASSWORD_LENGTH', 6);
-
 class Install extends PKPInstall
 {
     /**

diff --git a/classes/statistics/StatisticsHelper.inc.php b/classes/statistics/StatisticsHelper.inc.php
@@ -73,5 +73,5 @@ protected function getReportObjectTypesArray()
 
 if (!PKP_STRICT_MODE) {
     class_alias('\APP\statistics\StatisticsHelper', '\StatisticsHelper');
-    define('STATISTICS_DIMENSION_ISSUE_ID', \StatisticsHelper::STATISTICS_DIMENSION_ISSUE_ID);
+    define('STATISTICS_DIMENSION_ISSUE_ID', StatisticsHelper::STATISTICS_DIMENSION_ISSUE_ID);
 }
diff --git a/classes/subscription/InstitutionalSubscriptionDAO.inc.php b/classes/subscription/InstitutionalSubscriptionDAO.inc.php
@@ -715,7 +715,7 @@ public function _insertSubscriptionIPRanges($subscriptionId, $ipRanges)
 
         $returner = true;
 
-        while ([, $curIPString] = each($ipRanges)) {
+        foreach ($ipRanges as $curIPString) {
             $ipStart = null;
             $ipEnd = null;
 

diff --git a/plugins/importexport/doaj/filter/DOAJJsonFilter.inc.php b/plugins/importexport/doaj/filter/DOAJJsonFilter.inc.php
@@ -172,15 +172,6 @@ public function &process(&$pubObject)
             $article['bibjson']['keywords'] = $allowedNoOfKeywords;
         }
 
-        /* not needed here:
-        // Language
-        $language = AppLocale::get3LetterIsoFromLocale($pubObject->getLocale());
-        // publisherRecordId
-        $publisherRecordId = $pubObject->getId();
-        // documentType
-        $type = $pubObject->getType($pubObject->getLocale());
-        */
-
         $json = json_encode($article);
         return $json;
     }

diff --git a/plugins/reports/counter/index.php b/plugins/reports/counter/index.php
@@ -16,9 +16,6 @@
  *
  */
 
-// Because of the use of Namespaces, this plugin now requires PHP 5.3 or better
-if (version_compare(PHP_VERSION, '5.3.0') >= 0) {
-    require_once(dirname(__FILE__) . '/CounterReportPlugin.inc.php');
+require_once dirname(__FILE__) . '/CounterReportPlugin.inc.php';
 
-    return new CounterReportPlugin();
-}
+return new CounterReportPlugin();