pkp/pkp-lib#2564 Update tag configs for HTML title and use of PKPPubl…

…ication::********Title()
nibou230 · Feb 15, 2023 · ea10661 · ea10661
1 parent f5de50a
commit ea10661
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/config.TEMPLATE.inc.php b/config.TEMPLATE.inc.php
@@ -291,7 +291,7 @@
 
 ; Allowed HTML tags for submission titles only
 ; Unspecified attributes will be stripped.
-allowed_title_html = "strong,em,b,sup,sub"
+allowed_title_html = "b,i,u,sup,sub"
 
 ;N.b.: The implicit_auth parameter has been removed in favor of plugin implementations such as shibboleth
 

diff --git a/plugins/generic/htmlArticleGalley/templates/display.tpl b/plugins/generic/htmlArticleGalley/templates/display.tpl
@@ -44,7 +44,7 @@
 				{url page="article" op="download" path=$article->getBestId()|to_array:$galley->getBestGalleyId():$submissionFile->getId() inline=true}
 			{/capture}
 		{/if}
-		<iframe name="htmlFrame" src="{$htmlUrl}" title="{translate key="submission.representationOfTitle" representation=$galley->getLabel() title=$galleyPublication->getLocalizedFullTitle()|escape}" allowfullscreen webkitallowfullscreen></iframe>
+		<iframe name="htmlFrame" src="{$htmlUrl}" title="{translate key="submission.representationOfTitle" representation=$galley->getLabel() title=$galleyPublication->getLocalizedFullTitle(null, 'html')|unescape:'html'}" allowfullscreen webkitallowfullscreen></iframe>
 	</div>
 	{call_hook name="Templates::Common::Footer::PageFooter"}
 </body>

diff --git a/plugins/importexport/doaj/filter/DOAJJsonFilter.php b/plugins/importexport/doaj/filter/DOAJJsonFilter.php
@@ -112,7 +112,7 @@ public function &process(&$pubObject)
         }
 
         // Article title
-        $article['bibjson']['title'] = strip_tags($pubObject->getTitle($pubObject->getLocale()));
+        $article['bibjson']['title'] = $pubObject?->getCurrentPublication()?->getLocalizedTitle($pubObject->getLocale(), 'html') ?? '';
         // Identifiers
         $article['bibjson']['identifier'] = [];
         // DOI

diff --git a/plugins/importexport/doaj/filter/DOAJXmlFilter.php b/plugins/importexport/doaj/filter/DOAJXmlFilter.php
@@ -153,7 +153,7 @@ public function &process(&$pubObjects)
             }
             foreach ($articleTitles as $locale => $title) {
                 if (!empty($title)) {
-                    $recordNode->appendChild($node = $doc->createElement('title', htmlspecialchars(strip_tags($title), ENT_COMPAT, 'UTF-8')));
+                    $recordNode->appendChild($node = $doc->createElement('title', htmlspecialchars($title, ENT_COMPAT, 'UTF-8')));
                     $node->setAttribute('language', LocaleConversion::get3LetterIsoFromLocale($locale));
                 }
             }

diff --git a/plugins/reports/articles/ArticleReportPlugin.php b/plugins/reports/articles/ArticleReportPlugin.php
@@ -160,7 +160,7 @@ public function display($args, $request)
             // Store the submission results
             $results[] = [
                 'submissionId' => $submission->getId(),
-                'title' => $publication->getLocalizedFullTitle(),
+                'title' => htmlspecialchars($publication->getLocalizedFullTitle(null, 'html')),
                 'abstract' => html_entity_decode(strip_tags($publication->getLocalizedData('abstract'))),
                 'authors' => array_map(function ($author) {
                     return [

diff --git a/templates/frontend/pages/article.tpl b/templates/frontend/pages/article.tpl
@@ -17,7 +17,7 @@
  * @uses $primaryGalleys array List of article galleys that are not supplementary or dependent
  * @uses $supplementaryGalleys array List of article galleys that are supplementary
  *}
-{include file="frontend/components/header.tpl" pageTitleTranslated=$article->getLocalizedFullTitle()|escape}
+{include file="frontend/components/header.tpl" pageTitleTranslated=$article->getLocalizedFullTitle(null, 'html')|unescape:'html'}
 
 <div class="page page_article">
 	{if $section}