Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Windows and CPP17 compatibility #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

raymondyfei
Copy link

  • Member initializer is a C++20 feature. However, as suggested by the VFX reference platform, many toolchains still use C++17. In this PR, we make the code C++17 compatible.
  • Fixed a "divide by zero" compilation error on MSVC/VS2022 on Windows.
  • Fixed a missing header for std::sort and function Quat4f times(const Quat4f &a, const Quat4f &b) cannot return a constexpr with MSVC compiler.

@fortmeier
Copy link

nearly works for me with MSVC/VS2022: I need to add

#define _USE_MATH_DEFINES
#include "math.h"

in splat-types.h to make it work

@raymondyfei
Copy link
Author

raymondyfei commented Feb 4, 2025

nearly works for me with MSVC/VS2022: I need to add

#define _USE_MATH_DEFINES #include "math.h"

in splat-types.h to make it work

@fortmeier Thanks for the suggestion! Added to my branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants