-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update slash icon, update from XD, and and rename a few tokens #389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did the remaining steps for uptaking the token value changes (steps 1-8 of the nimble-tokens contributing doc) in this commit, if you want to pull that change into this PR.
(Currently this PR doesn't have the token renames in the token TS/CSS/CS files)
Would it be good to change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to pull in the commit that @msmithNI mentioned so that the token renames propagate all the way through to nimble-components.
Pull Request
🤨 Rationale
forward-slash
icon with proper iconEnterprise
green withForestGreen
Selection100
withDigitalGreenLight
Banner_Fail_100_DarkUI_
withBanner_Fail_100_DarkUI
DigitalGreenDark
,PowerGreen
, andBlack22
fillColorSelected
tofillSelectedColor
to match token naming schema.fill-selected-hover-color
tofill-hover-selected-color
to match token naming schema.👩💻 Implementation
Followed CONTRIBUTING docs to import new icon.
Used XD plugin to import latest Nimble_Components doc
🧪 Testing
Local builds and Storybook review
✅ Checklist