Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slash icon, update from XD, and and rename a few tokens #389

Merged
merged 12 commits into from
Mar 1, 2022

Conversation

fredvisser
Copy link
Contributor

@fredvisser fredvisser commented Feb 25, 2022

Pull Request

🤨 Rationale

  1. Replaces temporary forward-slash icon with proper icon
  2. Replaces Enterprise green with ForestGreen
  3. Replaces Selection100 with DigitalGreenLight
  4. Replaces Banner_Fail_100_DarkUI_ with Banner_Fail_100_DarkUI
  5. Adds DigitalGreenDark, PowerGreen, and Black22
  6. Rename fillColorSelected to fillSelectedColor to match token naming schema.
  7. Rename fill-selected-hover-color to fill-hover-selected-color to match token naming schema.

👩‍💻 Implementation

Followed CONTRIBUTING docs to import new icon.
Used XD plugin to import latest Nimble_Components doc

🧪 Testing

Local builds and Storybook review

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

Copy link
Contributor

@msmithNI msmithNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the remaining steps for uptaking the token value changes (steps 1-8 of the nimble-tokens contributing doc) in this commit, if you want to pull that change into this PR.

(Currently this PR doesn't have the token renames in the token TS/CSS/CS files)

@atmgrifter00
Copy link
Contributor

Would it be good to change fillColorSelected to fillSelectedColor as part of this PR, since it's already a major version change?

@rajsite rajsite mentioned this pull request Feb 26, 2022
1 task
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to pull in the commit that @msmithNI mentioned so that the token renames propagate all the way through to nimble-components.

@fredvisser fredvisser changed the title Update slash icon & add Update slash icon, update from XD, and and rename a few tokens Mar 1, 2022
@fredvisser fredvisser merged commit cf0ebf7 into main Mar 1, 2022
@fredvisser fredvisser deleted the add-slash-icon branch March 1, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants