Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens TypeScript Build #31

Merged
merged 4 commits into from
Jul 16, 2021
Merged

Tokens TypeScript Build #31

merged 4 commits into from
Jul 16, 2021

Conversation

rajsite
Copy link
Member

@rajsite rajsite commented Jul 16, 2021

Pull Request

🤨 Rationale

Added a workaround that avoids forking the DSP generated config.js and enables TypeScript Type Definitions for the JS Build. Could remove after: AdobeXD/design-system-package-dsp#22

👩‍💻 Implementation

Specified a custom config file in the DSP configuration. The custom file loads the one generated by the design system and patches it for the TypeScript configuration changes.

I noticed that even with a custom file specified the DSP plugin will still assume the original config.js exists and will always create or update it. The extend and patch workflow in nimble-config.js should allow us to leverage the GUI config for the DSP to generate a config.js and patch it for custom behavior in nimble-config.js.

🧪 Testing

Tested with the XD extension locally.

✅ Checklist

  • I have updated the project documentation to reflect my changes. Don't think any updates needed.

@rajsite rajsite changed the title Tokens ts build Tokens TypeScript Build Jul 16, 2021
@rajsite rajsite requested a review from fredvisser July 16, 2021 22:43
@rajsite
Copy link
Member Author

rajsite commented Jul 16, 2021

@fredvisser merging to test the beachball workflow with main branch protections turned on. When you get a chance to review I can do a follow-up with changes if needed.

@rajsite rajsite merged commit 9815168 into main Jul 16, 2021
@rajsite rajsite deleted the tokens-ts-build branch July 16, 2021 22:46
rajsite pushed a commit that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant