Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add String2DArray Output Support in Measurement packages and update relevant tests #1064

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Add String2DArray Output Support in Measurement packages and update relevant tests #1064

merged 5 commits into from
Feb 7, 2025

Conversation

Blahpapto1
Copy link
Contributor

@Blahpapto1 Blahpapto1 commented Feb 4, 2025 •
edited
Loading

What does this Pull Request accomplish?

  • Adding Support for String2DArray as an output message type in Client Generator and Service package.
  • Updated SampleMeasurement (with .measui) to highlight newly added String2DArray
  • Updated relevant tests.
  • Blocked Input Support for String2DArray.

Why should this Pull Request be merged?

Adding Support for String2DArraya in Client Generator and Service package. Also, updating SampleMeasurement and relevant tests.

What testing has been done?

  • Added tests for String2DArray in Service and Generator package.
  • Running SampleMeasurement with MeasUI Editor and dropping control that binds with string_2d_array_out works as expected.
  • PR run.

SampleAllParameters.measui -

Screenshot 2025-02-04 135306

SampleMeasurement.vi -

image

@Blahpapto1 Blahpapto1 changed the title Add String2DArray Output Support in Measurement packages and relevant tests Add String2DArray Output Support in Measurement packages and add relevant tests Feb 4, 2025
@Blahpapto1 Blahpapto1 changed the title Add String2DArray Output Support in Measurement packages and add relevant tests Add String2DArray Output Support in Measurement packages and update relevant tests Feb 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Test Results

    40 files  ±  0      40 suites  ±0   53m 42s ⏱️ + 1m 12s
   707 tests +  5     707 ✅ +  5      0 💤 ±0  0 ❌ ±0 
17 210 runs  +150  16 140 ✅ +150  1 070 💤 ±0  0 ❌ ±0 

Results for commit ec079fd. ± Comparison against base commit 9d74407.

♻️ This comment has been updated with latest results.

@Blahpapto1 Blahpapto1 marked this pull request as ready for review February 5, 2025 15:18
@Blahpapto1
Copy link
Contributor Author

FYI: @dixonjoel @bkeryan

@Blahpapto1 Blahpapto1 merged commit 0b961f4 into main Feb 7, 2025
17 checks passed
@Blahpapto1 Blahpapto1 deleted the users/avgoel/add-String2DArray-Support branch February 7, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkeryan bkeryan bkeryan approved these changes

@dixonjoel dixonjoel dixonjoel approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

@mshafer-NI mshafer-NI Awaiting requested review from mshafer-NI mshafer-NI is a code owner

@nstokes-nati nstokes-nati Awaiting requested review from nstokes-nati nstokes-nati is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blahpapto1 @bkeryan @dixonjoel