Fix LV code generation so that it honors source version of the project #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce only VIs. This allows the generated VIs to be saved in the correct source version for the project when using that feature with LV 2024 Q3 and later. Otherwise, you end up with a mix of VIs saved at the editor version and the source version specified by the project. - Updating template VIs that were not marked as source only. All template VIs should now be marked as source only. - Updating Save Library.vi so that it will automatically apply the library icon to all members of the library before saving. This ensures generated VIs that are added to the library have the correct icon when using a prototype library for the generation.
dixonjoel
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following issues with LV code generation from a .proto file:
Implementation
Set Source Only.vifor scripting. This is then used when creating new oneof conversion VIs from a template. I'm not certain why we don't have similar issues with creating new VIs from template using theNew VInode. I suspect it might be a bug with using a .vim template rather than a .vi template.Save Library.viso that it applies the library icon to all members before saving. This ensures newly created VIs during the generation process receive the icon as well. Without this, the members of the library were mixed in which ones displayed the icon and which ones didn't.Testing
I manually tested generation using proto files used by this repo which is where these issue were originally encountered.