Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make NewSession behave same way like UpdateSession method #594

Merged
merged 12 commits into from
Dec 9, 2024
Merged

fix: make NewSession behave same way like UpdateSession method #594

Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6b22b22
fix: allow custom claims to overwrite the default claims
xmlking Dec 1, 2024
df70e92
fix: make NewSession behave same way as UpdateSession and add Default…
xmlking Dec 5, 2024
a077ab8
fix: rollback jwt.go changes
xmlking Dec 5, 2024
c08bb28
Merge remote-tracking branch 'upstream/main'
xmlking Dec 6, 2024
08a14c3
fix: fix makezero lint error
xmlking Dec 6, 2024
0c2c776
fix: fix makezero lint error
xmlking Dec 7, 2024
bdbbc41
fix: fix makezero lint error
xmlking Dec 7, 2024
a7c2795
Merge remote-tracking branch 'upstream/main'
xmlking Dec 9, 2024
6622f86
fix: added nolint:funlen comment
xmlking Dec 9, 2024
6d9e96c
Merge branch 'main' into main
dbarrosop Dec 9, 2024
8dc1de3
Merge remote-tracking branch 'upstream/main'
xmlking Dec 9, 2024
652990a
Merge remote-tracking branch 'refs/remotes/origin/main'
xmlking Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions go/controller/workflows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,9 +467,13 @@ func (wf *Workflows) NewSession(
if err != nil {
return nil, fmt.Errorf("error getting roles by user id: %w", err)
}
allowedRoles := make([]string, len(userRoles))
for i, role := range userRoles {
allowedRoles[i] = role.Role
allowedRoles := make([]string, 0, len(userRoles))
for _, role := range userRoles {
allowedRoles = append(allowedRoles, role.Role)
}

if !slices.Contains(allowedRoles, user.DefaultRole) {
allowedRoles = append(allowedRoles, user.DefaultRole)
}

refreshToken := uuid.New()
Expand Down