-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make NewSession behave same way like UpdateSession method #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Role to allowedRoles if missing in it
xmlking
changed the title
fix: make NewSession behave same way like UpdateSession method
fix: make UpdateSession behave same way like NewSession method
Dec 7, 2024
xmlking
changed the title
fix: make UpdateSession behave same way like NewSession method
fix: make NewSession behave same way like UpdateSession method
Dec 7, 2024
the patch is verified with this testing project |
dbarrosop
approved these changes
Dec 9, 2024
LGTM we need to make the linter happy though, I'd suggest just disabling the funlen check like in the UpdateSession method so just add Also, rebase so you get the CI fix from here: #596 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR:
Noticed session creation behave is different when
UpdateSession
method is called vsNewSession
method is called.keeping the behavior same for both methods, producing similar
allowedRoles
in session.Checklist
Breaking changes
Avoid breaking changes and regressions. If you feel it is unavoidable, make it explicit in your PR comment so we can review it and see how to handle it.
Tests
make test
or themake watch
command).Documentation
Please make sure the documentation is updated accordingly, in particular: