feat: add host binding migration #528
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostromeckyp
force-pushed
the
feat/migrate-host-binding-to-host-in-decorator
branch
from
8277454 to
be0b123
Compare
ostromeckyp
force-pushed
the
feat/migrate-host-binding-to-host-in-decorator
branch
from
be0b123 to
24f0916
Compare
|
@eneajaho kindly asking for a review |
eneajaho
reviewed
Jan 2, 2025
Comment on lines
+1
to
+7
| --- | ||
| title: Queries Migration | ||
| description: Schematics for migrating from decorator-based Queries to Signal-based Queries | ||
| entryPoint: plugin/src/generators/convert-queries | ||
| badge: stable | ||
| contributors: ['enea-jahollari'] | ||
| --- |
eneajaho
reviewed
Jan 2, 2025
| contributors: ['enea-jahollari'] | ||
| --- | ||
|
|
||
| Recent releases of Angular have deprecated the `@HostBinding` and `@HostListener` decorators, replacing them with `host` defined properties. This migration schematic will help you convert your existing `@HostBinding` and `@HostListener` decorators to the new `host` properties. |
There was a problem hiding this comment.
The decorators are not yet deprecated
eneajaho
reviewed
Jan 2, 2025
| import { convertHostBindingGenerator } from './generator'; | ||
| import { ConvertHostBindingGeneratorSchema } from './schema'; | ||
|
|
||
| const filesMap = { |
There was a problem hiding this comment.
I'd like to see some more test cases. And before we merge this one, we will need to make sure that we don't break apps.
|
@ostromeckyp This PR needs a rebase. Also, just to let you know, we probably will get this merged in ngxtension, but I'm also working on a prototype that does the same thing, but working on getting it directly in the Angular repo, as that would make it easier for everyone to use. But, because ngxtension already supports a lot of schematics, we can get this merged and out before I can get mine ready for the Angular one. Thanks for creating this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.