-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Enhance inject route utilities #450
base: main
Are you sure you want to change the base?
Conversation
is this still WIP? |
Yes, docs and tests are missing. |
0c240e0
to
231fb26
Compare
Hello @Dafnik Regarding
I think initialValue is a better fit there because after the initialValue, the params can change however the router needs, and we shouldn't call it default value (as that would mean that we will reapply it again based on some condition, which we don't because we only need it the first time). |
Hi, thank you very much :) But it is actually a default value. 😅 Lets say we have the route Or did I get this wrong? |
Ping @eneajaho |
This one should be included in the docs too https://timdeschryver.dev/blog/til-paramsinheritancestrategy-to-always-have-access-to-parent-route-info |
Hello @Dafnik As you may have already seen, I've published linkedQueryParam, https://ngxtension.netlify.app/utilities/injectors/linked-query-param/ In order for things to be consistent, I'd like to convert the method transform to be called So, all the utils should contain: If you don't have time to finish this one, I can take over anytime. Please let me know, as I'd like to get these features out as they are really needed. Happy new year ✨ |
Btw, just re-read this one reply #495 (comment) Looks like I can take over 🙌 |
Yeah please take it over! The parse function sound good for me! I've already tried out linkedQueryParams and I love it!! Really great UX and much better than just having injectQueryParams. |
Adds the following options to all utilities and therefore aligns them.
I also took the chance to rename
initialValue
todefaultValue
(as I think it's a more fitting name).injectQueryParams
supports both values, as to not introduce a breaking change.Tests are still missing.