Skip to content

Commit

Permalink
fix: lumberjack, angular peer dependency versions (#202)
Browse files Browse the repository at this point in the history
## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] The commit message follows our guidelines: CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

```
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
```

## What is the current behavior?

We didn't update the Lumberjack peer dependencies when upgrading to
Angular 16

## What is the new behavior?

We use the proper peer dependencies for Lumberjack and Angular 16

## Does this PR introduce a breaking change?

```
[ ] Yes
[x] No
```
  • Loading branch information
NachoVazquez authored Jan 24, 2024
1 parent 08b54ba commit 52ebcb7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/ngworker/lumberjack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
"url": "https://github.com/ngworker/lumberjack/issues?q=is:issue+is:open+"
},
"peerDependencies": {
"@angular/core": "^15.0.1",
"@angular/common": "^15.0.1",
"@angular/core": "^16.0.0",
"@angular/common": "^16.0.0",
"rxjs": ">= 7.5.0 < 8.0.0"
},
"peerDependenciesMeta": {
Expand Down

0 comments on commit 52ebcb7

Please sign in to comment.