refactor(store-devtools): resolve import cycle to improve tool compatibility #4662
+6
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change resolves the cyclical import dependency
`store-devtools/src/{provide-store-devtools <-> instrument}.ts` by
moving `createStateObservable` to `provide-store-devtools.ts`, its only
user.
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
raphinesse
changed the title
raphinesse
commented
Jan 8, 2025
| import { StoreDevtools } from './devtools'; | ||
|
|
||
| export function createStateObservable( |
There was a problem hiding this comment.
Arguably the export here is not required anymore. WDYT?
Suggested change
| export function createStateObservable( | |
| function createStateObservable( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves the cyclical import dependency
store-devtools/src/{provide-store-devtools <-> instrument}.tsby movingcreateStateObservabletoprovide-store-devtools.ts, its only user.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The import cycle breaks TS language tools/environments (e.g. Google's TS build) that don't support cyclical imports.
What is the new behavior?
Support TS language tools/environments that don't support cyclical imports.
Does this PR introduce a breaking change?
Other information