CI Setup with GitHub Actions and NGINX Perl Test Updates #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed api and keyval from NGINX test requirements due to their absence in default package builds, ensuring tests run properly without them.
Adjusted the test to match a more generic error pattern, accounting for variations in crypto library versions.
jimf5
reviewed
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of GitHub Actions workflow for perl-based tests.
Removal of unnecessary modules from test requirements. The modules 'api' and 'keyval' have been removed from the module requirements in the perl-based tests. These modules are included by default in NGINX Plus builds but are not explicitly listed in the
nginx -Voutput.Refinement of error message check in tests. The error message check in the 'wrong cert type' test has been refined to account for variations in crypto library error messages.