Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final Edits #17

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Final Edits #17

merged 6 commits into from
Jan 17, 2025

Conversation

sdutta9
Copy link
Collaborator

@sdutta9 sdutta9 commented Jan 17, 2025

Proposed changes

  • Updated missing images
  • Removed Placeholder lab links from the labguide
  • Standardized Nginx to NGINX across all the lab exercises.
  • Standardized NGINX One, One console to NGINX One Console across all the lab exercises.

apcurrier
apcurrier approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@apcurrier apcurrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would update the seated-developer image, but everything else looks good to me.

@sdutta9 sdutta9 merged commit b5f7bae into main Jan 17, 2025
1 check failed
@sdutta9 sdutta9 deleted the sd branch January 17, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apcurrier apcurrier apcurrier approved these changes

@chrisakker chrisakker Awaiting requested review from chrisakker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdutta9 @apcurrier