unitctl: fixes for openssl and docker client #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ava Hahn <[email protected]>
|
Does the move to hyper-rustls mean that the resulting binary will not be linked to openssl anymore? |
Yes. I verified this with ldd on x86_64. |
javorszky
approved these changes
Sep 24, 2024
Signed-off-by: Ava Hahn <[email protected]>
avahahn
force-pushed
the
ava-openssl
branch
from
f3405a7 to
aefc922
Compare
javorszky
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains commits to fix both #1439 and #1438.
The OpenSSL issue is solved by moving to hyper-rustls from hyper-tls.
The docker client error (hyper legacy client connect error) is solved by bumping the bollard library version and also just in case I have elaborated on the error print text.
Both issues were tested on Debian latest docker image (x86_64) as well as M1 (aarch64) OSX.
Help verifying on an aarch64 Linux box is welcome, but I expect similar results.