Add Event timers and supporting utilities (+ lint and fmt) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ava Hahn <[email protected]>
Signed-off-by: Ava Hahn <[email protected]>
Signed-off-by: Ava Hahn <[email protected]>
Signed-off-by: Ava Hahn <[email protected]>
Signed-off-by: Ava Hahn <[email protected]>
Signed-off-by: Ava Hahn <[email protected]>
Signed-off-by: Ava Hahn <[email protected]>
Signed-off-by: Ava Hahn <[email protected]>
Signed-off-by: Ava Hahn <[email protected]>
Signed-off-by: Ava Hahn <[email protected]>
Signed-off-by: Ava Hahn <[email protected]>
Signed-off-by: Ava Hahn <[email protected]>
Signed-off-by: Ava Hahn <[email protected]>
- New log macro that accepts NGX_LOG_DEBUG bitmask filters - Add logging to events - Updated internal_redirect to call request methods: - ngx_named_location, ngx_internal_redirect which accepts args - Subrequest flags for masking and state - Subrequest accepts query parameters as the arg flag - Quelling lint errors and warnings - Quelling fmt workflow errors
|
@f5yacobucci Please remove links to not publicly available repositories. |
Can do, can you point me to an example? I'm not seeing one at the moment. Should just be nginx.org dev guide links, but I'll continue to scrub. |
ivanitskiy
reviewed
Jun 20, 2023
| @@ -70,11 +70,9 @@ pub use bindings::*; | |||
| /// let data: &str = "example"; // The string to convert | |||
| /// let ptr = str_to_uchar(pool, data); | |||
| /// ``` | |||
| pub fn str_to_uchar(pool: *mut ngx_pool_t, data: &str) -> *mut u_char { | |||
| pub unsafe fn str_to_uchar(pool: *mut ngx_pool_t, data: &str) -> *mut u_char { | |||
There was a problem hiding this comment.
why is that? when unsafe is used in the body of the fn, it is safe to invoke it, otherwise, the caller must use unsafe to unsafe { str_to_uchar(...) } . it is definitely might break many existing codes, let's keep it back.
what's the reason?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes