Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove flags no longer needed #806

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Remove flags no longer needed #806

merged 3 commits into from
Sep 30, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

-trimpath is all that is needed, the other flags force the path to GOPATH and that is not always the correct path.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome lucacome self-assigned this Sep 26, 2024
@lucacome lucacome requested a review from a team as a code owner September 26, 2024 05:47
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 26, 2024
@lucacome lucacome enabled auto-merge (squash) September 30, 2024 15:30
@lucacome lucacome merged commit c6dddba into main Sep 30, 2024
13 checks passed
@lucacome lucacome deleted the chore/remove-flags branch September 30, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacome @jjngx