-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add auth_jwt_claim_set in nginx plus virtualserver template #7205
Merged
+184
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haywood Shannon <[email protected]> Signed-off-by: Haywood Shannon <[email protected]>
github-actions
bot
added
enhancement
Pull requests for new features/feature enhancements
go
Pull requests that update Go code
labels
Jan 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7205 +/- ##
==========================================
- Coverage 52.72% 52.71% -0.01%
==========================================
Files 89 89
Lines 20843 20843
==========================================
- Hits 10989 10987 -2
Misses 9396 9396
- Partials 458 460 +2 ☔ View full report in Codecov by Sentry. |
pdabelf5
force-pushed
the
feat/rate-limit-jwt-claim-template
branch
from
January 27, 2025 10:33
39a4d33
to
0e21880
Compare
vepatel
approved these changes
Jan 28, 2025
jjngx
approved these changes
Jan 28, 2025
AlexFenlon
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Pull requests for new features/feature enhancements
go
Pull requests that update Go code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR is the first in a series to implement the tiered rate-limits based on JWT claims feature. It updates the VirtualServer nginx plus templates to allow setting the
auth_jwt_claim_set
directive. It defines theAuthJwtClaimSet
struct to contain the directive values.Future PR's will drive the content to populate these data structures.
Checklist
Before creating a PR, run through this checklist and mark each as complete.