Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand mgmt configmap tests #7000

Conversation

nginx-bot
Copy link
Contributor

Proposed changes

Add further tests to validate parameters passed to the mgmt configmap

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-bot nginx-bot requested a review from a team as a code owner December 16, 2024 12:56
@nginx-bot nginx-bot added go Pull requests that update Go code needs cherry pick Cherry pick this PR into a release branch labels Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-4.0@0a5e471). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/configs/configmaps.go 40.00% 4 Missing and 2 partials ⚠️
internal/validation/validation.go 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             release-4.0    #7000   +/-   ##
==============================================
  Coverage               ?   52.74%           
==============================================
  Files                  ?       89           
  Lines                  ?    20824           
  Branches               ?        0           
==============================================
  Hits                   ?    10983           
  Misses                 ?     9387           
  Partials               ?      454           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed go Pull requests that update Go code needs cherry pick Cherry pick this PR into a release branch labels Dec 16, 2024
@pdabelf5 pdabelf5 changed the title [cherry-pick] Expand mgmt configmap tests Expand mgmt configmap tests Dec 16, 2024
@pdabelf5 pdabelf5 added tests Pull requests that update tests and removed chore Pull requests for routine tasks labels Dec 16, 2024
@pdabelf5 pdabelf5 enabled auto-merge (squash) December 16, 2024 13:45
@github-actions github-actions bot added go Pull requests that update Go code and removed tests Pull requests that update tests labels Dec 16, 2024
@pdabelf5 pdabelf5 merged commit 16ed0fd into release-4.0 Dec 16, 2024
70 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-release-4.0-6103b0adcf0894489974fbd673e356a5368d882e branch December 16, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants