Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

symlink to central secret #6714

Merged
merged 36 commits into from
Dec 20, 2024
Merged

symlink to central secret #6714

merged 36 commits into from
Dec 20, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Oct 28, 2024 •
edited
Loading

Proposed changes

Update where possible to use centralised TLS secrets so they can be updated in one place

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks documentation Pull requests/issues for documentation labels Oct 29, 2024
@github-actions github-actions bot removed github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Oct 31, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.73%. Comparing base (2e0daa1) to head (b69af07).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6714   +/-   ##
=======================================
  Coverage   52.73%   52.73%           
=======================================
  Files          89       89           
  Lines       20824    20824           
=======================================
  Hits        10981    10981           
  Misses       9389     9389           
  Partials      454      454

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 marked this pull request as ready for review December 19, 2024 16:22
@pdabelf5 pdabelf5 requested a review from a team as a code owner December 19, 2024 16:22
@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Dec 19, 2024
jjngx
jjngx approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pdabelf5 pdabelf5 enabled auto-merge (squash) December 20, 2024 12:08
@pdabelf5 pdabelf5 merged commit c4f35e9 into main Dec 20, 2024
79 checks passed
@pdabelf5 pdabelf5 deleted the common-tls-secrets branch December 20, 2024 12:16
nginx-bot pushed a commit that referenced this pull request Dec 20, 2024
@pdabelf5 @web-flow
symlink to central secret (#6714)
4d60698
@pdabelf5 pdabelf5 mentioned this pull request Dec 20, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch python Pull requests that update Python code tests Pull requests that update tests
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdabelf5 @vepatel @AlexFenlon @jjngx