-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
symlink to central secret #6714
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdabelf5
force-pushed
the
common-tls-secrets
branch
from
October 28, 2024 11:03
bb0ff45
to
4053d01
Compare
github-actions
bot
added
python
Pull requests that update Python code
tests
Pull requests that update tests
github_actions
Pull requests that update Github_actions code
chore
Pull requests for routine tasks
documentation
Pull requests/issues for documentation
labels
Oct 29, 2024
pdabelf5
force-pushed
the
common-tls-secrets
branch
from
October 31, 2024 11:06
74e458d
to
a39f4a4
Compare
github-actions
bot
removed
github_actions
Pull requests that update Github_actions code
chore
Pull requests for routine tasks
labels
Oct 31, 2024
pdabelf5
force-pushed
the
common-tls-secrets
branch
from
December 19, 2024 09:51
e535d20
to
a8ce909
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6714 +/- ##
=======================================
Coverage 52.73% 52.73%
=======================================
Files 89 89
Lines 20824 20824
=======================================
Hits 10981 10981
Misses 9389 9389
Partials 454 454 ☔ View full report in Codecov by Sentry. |
pdabelf5
force-pushed
the
common-tls-secrets
branch
from
December 19, 2024 12:26
4fbac73
to
ba45012
Compare
jjngx
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
AlexFenlon
approved these changes
Dec 20, 2024
vepatel
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Pull requests/issues for documentation
needs cherry pick
Cherry pick this PR into a release branch
python
Pull requests that update Python code
tests
Pull requests that update tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update where possible to use centralised TLS secrets so they can be updated in one place
Checklist
Before creating a PR, run through this checklist and mark each as complete.