Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync oidc repo #6014

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Sync oidc repo #6014

merged 2 commits into from
Jul 18, 2024

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Jul 12, 2024 •
edited
Loading

Proposed changes

sync changes from oidc repo https://github.com/nginxinc/nginx-openid-connect/pull/96/files

Changes from https://github.com/nginxinc/nginx-openid-connect/pull/96/files#diff-512d27cf176962c2b1cffd370bbd1adba80368558ad4aaa2a6255eea9ff453bdR31-R37 is ignored because the variable should be set from the NGINX conf generated by NIC.

Testing:
Works with existing OIDC keycloak set up on main branch (without logout ).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@haywoodsh haywoodsh force-pushed the chore/sync-oidc-repo branch 3 times, most recently from 193ac39 to a1f4f09 Compare July 15, 2024 11:31
@haywoodsh haywoodsh added dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels Jul 15, 2024
@haywoodsh
sync oidc repo
3d4f5e6 
Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>
@haywoodsh haywoodsh force-pushed the chore/sync-oidc-repo branch from a1f4f09 to 3d4f5e6 Compare July 18, 2024 11:06
@github-actions github-actions bot removed dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels Jul 18, 2024
@haywoodsh haywoodsh marked this pull request as ready for review July 18, 2024 11:07
@haywoodsh haywoodsh requested a review from a team as a code owner July 18, 2024 11:07
@haywoodsh haywoodsh enabled auto-merge (squash) July 18, 2024 15:23
@haywoodsh haywoodsh merged commit f51b894 into main Jul 18, 2024
80 checks passed
@haywoodsh haywoodsh deleted the chore/sync-oidc-repo branch July 18, 2024 15:27
@pdabelf5 pdabelf5 added the enhancement Pull requests for new features/feature enhancements label Sep 23, 2024
@pdabelf5 pdabelf5 changed the title sync oidc repo Sync oidc repo Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haywoodsh @vepatel @AlexFenlon @pdabelf5