Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some python tests from vs1 to vs2 #5888

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Move some python tests from vs1 to vs2 #5888

merged 2 commits into from
Jun 28, 2024

Conversation

j1m-ryan
Copy link

@j1m-ryan j1m-ryan commented Jun 28, 2024 •
edited
Loading

Proposed changes

Old VS Plus times

  1. 22m (collecting ... collected 530 items / 454 deselected / 76 selected)
  2. 7m (collecting ... collected 530 items / 507 deselected / 23 selected)
  3. 16m (collecting ... collected 530 items / 498 deselected / 32 selected)

New VS Plus times

  1. 16m (collecting ... collected 530 items / 480 deselected / 50 selected)
  2. 13m (collecting ... collected 530 items / 481 deselected / 49 selected)
  3. 16m collecting ... collected 530 items / 498 deselected / 32 selected) Unchanged

76 + 23 = 50 + 49 = 99

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner June 28, 2024 13:51
@github-actions github-actions bot added python Pull requests that update Python code chore Pull requests for routine tasks tests Pull requests that update tests labels Jun 28, 2024
@j1m-ryan j1m-ryan added the needs cherry pick Cherry pick this PR into a release branch label Jun 28, 2024
@shaun-nx shaun-nx added this to the v3.6.1 milestone Jun 28, 2024
@j1m-ryan j1m-ryan enabled auto-merge (squash) June 28, 2024 14:31
@j1m-ryan j1m-ryan merged commit 715141e into main Jun 28, 2024
84 checks passed
@j1m-ryan j1m-ryan deleted the chore/further-split-vs-matrix branch June 28, 2024 14:46
AlexFenlon pushed a commit that referenced this pull request Jul 1, 2024
@AlexFenlon
Move some python tests from vs1 to vs2 (#5888)
c3de814 
more tests from vs1 to vs2
@AlexFenlon AlexFenlon mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseoin oseoin oseoin approved these changes

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@jjngx jjngx jjngx approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks needs cherry pick Cherry pick this PR into a release branch python Pull requests that update Python code tests Pull requests that update tests
Projects
NGINX Ingress Controller
Archived in project
Milestone
v3.6.1
Development

Successfully merging this pull request may close these issues.
7 participants
@j1m-ryan @oseoin @vepatel @AlexFenlon @jjngx @pdabelf5 @shaun-nx