-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process namespace sharing for ingress controller #4559
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4559 +/- ##
==========================================
+ Coverage 51.96% 51.99% +0.02%
==========================================
Files 59 59
Lines 16960 16960
==========================================
+ Hits 8814 8818 +4
+ Misses 7849 7847 -2
+ Partials 297 295 -2 ☔ View full report in Codecov by Sentry. |
@panzouh there are a few things missing from this PR.
|
Of course, given the fact that these modifications are not described in the contribute guide nor in the precommit config meaning that i should do it manually right ? If it is indeed the case updated it on 76074a2b3d98332f7b9ca30304097cd6e8175445 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panzouh LGTM, but seems like you need to rebase your branch.
455c52c
to
6e08859
Compare
6d12d85
to
4f11955
Compare
HI @panzouh was having some problems with the pipeline. I'm re-running the failed jobs now. |
Proposed changes
The changes allow to configure process namespace sharing for a pod.
Solves : #4558
Checklist
Before creating a PR, run through this checklist and mark each as complete.