Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove deprecated docs with draft: true value #55

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Jcahilltorre
Copy link
Contributor

Proposed changes

  • Remove docs tagged with draft: true with deprecated content (as opposed to work in progress content)
  • Remove 3 references to a removed list-page (which had no content)

Testing: Local build throws no errors

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

@Jcahilltorre Jcahilltorre requested a review from a team as a code owner January 8, 2025 17:35
Copy link

github-actions bot commented Jan 8, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@Jcahilltorre
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@mjang mjang requested a review from travisamartin January 8, 2025 17:51
@mjang
Copy link
Collaborator

mjang commented Jan 8, 2025

@travisamartin this affects the NIM files that you changed heavily, so you should be the prime approver

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Jan 8, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/55/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants