Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.0 #528

Merged
merged 581 commits into from
Mar 18, 2024
Merged

Release 2.0.0 #528

merged 581 commits into from
Mar 18, 2024

Conversation

ramprasadn
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

jemten and others added 30 commits January 10, 2024 15:45
Updating vcf2cytosure and tiddit cov
Change hardcoded platform value to params.platform in modules/align_MT.config
nextflow.config Outdated Show resolved Hide resolved
// Generate methods description for MultiQC
//
def toolCitationText() {
// TODO nf-core: Optionally add in-text citation tools to this list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are three TODOs left in subworkflows/local/utils_nfcore_raredisease_pipeline/main.nf. I don't know whether it is important.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the list of citations in CITATIONS.md already, so I think its better to keep just that one updated as we go. I will remove the TODO statements 😄

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These citations are added to the Multiqc report. Maybe worth to add them there?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrite! It was a struggle, but its finally in there now 😆

@jemten jemten linked an issue Mar 8, 2024 that may be closed by this pull request
@ramprasadn ramprasadn requested review from maxulysse and asp8200 March 13, 2024 16:08
@ramprasadn
Copy link
Collaborator Author

I realized that Peddy was not in the multiqc config, but I have fixed that now. The PR is ready for review! 😀

@asp8200
Copy link
Contributor

asp8200 commented Mar 14, 2024

I realized that Peddy was not in the multiqc config, but I have fixed that now. The PR is ready for review! 😀

Cool. Did you test that the peddy in the multiqc-config works?

@ramprasadn
Copy link
Collaborator Author

Yupe! It works :)

@maxulysse
Copy link
Member

Check up your subway maps, the dark/light bits are a bit mixed

@ramprasadn ramprasadn merged commit 30e2781 into master Mar 18, 2024
13 checks passed
@asp8200
Copy link
Contributor

asp8200 commented Mar 18, 2024

Congrats, Ram 🥳 👏👏👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URGENT: pin nf-validation version
8 participants