-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.0.0 #528
Release 2.0.0 #528
Conversation
Updating vcf2cytosure and tiddit cov
Add found_in tag to vcf
Change hardcoded platform value to params.platform in modules/align_MT.config
adds schema for svdb query inputs
// Generate methods description for MultiQC | ||
// | ||
def toolCitationText() { | ||
// TODO nf-core: Optionally add in-text citation tools to this list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are three TODOs left in subworkflows/local/utils_nfcore_raredisease_pipeline/main.nf
. I don't know whether it is important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the list of citations in CITATIONS.md already, so I think its better to keep just that one updated as we go. I will remove the TODO statements 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These citations are added to the Multiqc report. Maybe worth to add them there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrite! It was a struggle, but its finally in there now 😆
subworkflows/local/variant_calling/call_sv_germlinecnvcaller.nf
Outdated
Show resolved
Hide resolved
…tion fix: parameters not resolving properly when igenomes are used
I realized that Peddy was not in the multiqc config, but I have fixed that now. The PR is ready for review! 😀 |
Cool. Did you test that the peddy in the multiqc-config works? |
Yupe! It works :) |
Check up your subway maps, the dark/light bits are a bit mixed |
Congrats, Ram 🥳 👏👏👏 |
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).