Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated AF2 standard Dockerfile #239

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

jscgh
Copy link

@jscgh jscgh commented Jan 10, 2025

PR checklist

Updates the AF2 standard image as per #221

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>
  • CHANGELOG.md is updated.

@jscgh jscgh marked this pull request as ready for review January 10, 2025 03:05
@JoseEspinosa
Copy link
Member

I have updated the docker image but forgot to commit the Dockerfile and is actually here 😓
Since you have done it already @jscgh I will build the image again with your Dockerfile and test it and if everything is fine I will then merge your PR and update the image on quay.io

Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there seem to be some files leak on this PR that overwrite some changes introduced by the last template update, it would be great if you could revert them again @jscgh

This reverts commit 8cb90ad.
@jscgh
Copy link
Author

jscgh commented Jan 16, 2025

I see there seem to be some files leak on this PR that overwrite some changes introduced by the last template update, it would be great if you could revert them again @jscgh

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants