Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter step to CI to exclude some tests for some profiles #7273

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Add filter step to CI to exclude some tests for some profiles #7273

merged 4 commits into from
Jan 9, 2025
+165 −201

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Jan 7, 2025

No description provided.

@mashehu mashehu requested a review from a team as a code owner January 7, 2025 16:52
@mashehu mashehu mentioned this pull request Jan 7, 2025
Open
SPPearce
SPPearce reviewed Jan 8, 2025
View reviewed changes
.github/skip_nf_test.yml Outdated Show resolved Hide resolved
@mashehu mashehu added the WIP Work in progress label Jan 9, 2025
@mashehu mashehu marked this pull request as draft January 9, 2025 08:20
@mashehu mashehu mentioned this pull request Jan 9, 2025
Merged
@mashehu mashehu marked this pull request as ready for review January 9, 2025 15:08
@mashehu mashehu removed the WIP Work in progress label Jan 9, 2025
edmundmiller
edmundmiller approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Keeping it in a separate file is a real improvement from being in the GitHub action workflow.

I propose we lock the workflow files down to code owners to prevent any wild modifications without review from infrastructure.

@mashehu
Copy link
Contributor Author

mashehu commented Jan 9, 2025

I propose we lock the workflow files down to code owners to prevent any wild modifications without review from infrastructure.

You mean all of your modifications? 😜

@maxulysse
Copy link
Member

I propose we lock the workflow files down to code owners to prevent any wild modifications without review from infrastructure.

You mean all of your modifications? 😜

🔥

@mashehu
Copy link
Contributor Author

mashehu commented Jan 9, 2025

I propose we lock the workflow files down to code owners

as far as I can see, that is already the case or I don't know about that specific setting

@mashehu mashehu added this pull request to the merge queue Jan 9, 2025
Merged via the queue into master with commit 667f74c Jan 9, 2025
13 checks passed
@mashehu mashehu deleted the add-conda-skip-step branch January 9, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sateeshperi sateeshperi sateeshperi approved these changes

@SPPearce SPPearce SPPearce left review comments

@edmundmiller edmundmiller edmundmiller approved these changes

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mashehu @maxulysse @edmundmiller @SPPearce @sateeshperi