Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge template 2.13. #234

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Merge template 2.13. #234

merged 6 commits into from
Feb 23, 2024

Conversation

jonasscheid
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/epitopeprediction branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 22, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 155b80f

+| ✅ 177 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-epitopeprediction_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-epitopeprediction_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-epitopeprediction_logo_dark.png

✅ Tests passed:

Run details

  • nf-core/tools version 2.13
  • Run at 2024-02-23 08:33:45

@jonasscheid
Copy link
Contributor Author

jonasscheid commented Feb 22, 2024 •
edited
Loading

@christopher-mohr thoughts on this? Running the tests locally worked fine

edit: Runs on nf 23.04 and 23.10
edit edit: Error reproducible on gitpod

@christopher-mohr
Copy link
Collaborator

@christopher-mohr thoughts on this? Running the tests locally worked fine

edit: Runs on nf 23.04 and 23.10 edit edit: Error reproducible on gitpod

Not sure what's currently going on there. Still worked on the release PR. Maybe some issues on ensembl` side.

@christopher-mohr
Copy link
Collaborator

christopher-mohr commented Feb 23, 2024 •
edited
Loading

Can't reproduce on gitpod using dev

edit: because the test_grch38 profile on dev was wrong.

@christopher-mohr
Copy link
Collaborator

Fix is on dev, if you merge that, it should work. :)

@jonasscheid
Copy link
Contributor Author

jonasscheid commented Feb 23, 2024 •
edited
Loading

Great thanks! Always a minor thing with biomart, but hard to find🤦🏼. Can we push the release through today?

christopher-mohr
christopher-mohr approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopher-mohr christopher-mohr merged commit 84252c5 into nf-core:dev Feb 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopher-mohr christopher-mohr christopher-mohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonasscheid @christopher-mohr @nf-core-bot