Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional scree plot to report #192

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Add optional scree plot to report #192

merged 5 commits into from
Nov 13, 2023

Conversation

WackerO
Copy link
Collaborator

@WackerO WackerO commented Nov 8, 2023

This PR adds a scree plot to the report; it is optional, --report_scree is for now false by default:
SRP254919_scree.html.zip

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Nov 8, 2023

nf-core lint overall result: Passed ✅

Posted for pipeline commit ce7999f

+| ✅ 160 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-11-09 12:08:02

Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just needs to be simplified since we have duplicate plots right now.

assets/differentialabundance_report.Rmd Outdated Show resolved Hide resolved
nextflow.config Outdated Show resolved Hide resolved
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WackerO WackerO merged commit 14e89bc into nf-core:dev Nov 13, 2023
14 checks passed
@WackerO WackerO deleted the scree branch November 13, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants