Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump vcf2db #226

Merged
merged 2 commits into from
Nov 19, 2024
Merged

bump vcf2db #226

merged 2 commits into from
Nov 19, 2024

Conversation

matthdsm
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@matthdsm matthdsm requested a review from nvnieuwk November 19, 2024 08:15
@nvnieuwk
Copy link
Member

Can you fix the vcf2db tests and patch them? nf-test test modules/nf-core/vcf2db --update-snapshot. the test is failing due to a config in the pipeline but it's still valid in the context of the pipeline

@nvnieuwk nvnieuwk merged commit 507c403 into dev Nov 19, 2024
32 checks passed
@nvnieuwk nvnieuwk deleted the bump/vcf2db branch November 19, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants