Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nf test local subworkflows #224

Merged
merged 27 commits into from
Nov 19, 2024
Merged

Nf test local subworkflows #224

merged 27 commits into from
Nov 19, 2024

Conversation

nvnieuwk
Copy link
Member

@nvnieuwk nvnieuwk commented Nov 14, 2024 •
edited
Loading

This PR adds tests for all subworkflows, a small restriction to the sample and family name to fix an issue in the multiqc report and makes sure all tests will be run on a PR to main

@nvnieuwk
move subwf tests to the subwf folder
b0236dd
@nvnieuwk
add restrictions on sample and family name
ddb39a2
@nvnieuwk
Merge branch 'nf-test-local-modules' into nf-test-local-subworkflows
2830175
@nvnieuwk
test vcf_concat_bcftools
9d4db4f
@nvnieuwk
test vcf_filter_bcftools
5d1f117
@nvnieuwk
add a test coverage ci comment
37f15b5
@nvnieuwk
pre-commit
d24dc42
@nvnieuwk
print out the coverage in the ci logs
883a606
@nvnieuwk
fix missing $ in coverage action
53a3f76
@nvnieuwk
update shell
de81099
@nvnieuwk
try another method
df481a3
@nvnieuwk
use env instead
81ae13b
@nvnieuwk
use another env method
8a62fad
@nvnieuwk
use another env method
816d411
@nvnieuwk
try even more methods
1feca5f
@nvnieuwk
convert points to -
c8c0fa3
@nvnieuwk
fix wrongly place quote
4b495e3
@nvnieuwk
retrigger ci tests
94af572
@nvnieuwk
forget coverage
fd97047
@nvnieuwk
add triggers for full test runs
6611a85
@nvnieuwk
run all tests on PRs to main
344f240
@nvnieuwk
fix if statement
382e015
@nvnieuwk
fix test vcf_ped_rtgtools + fix ci
8c50b03
@nvnieuwk
fix cram prepare subwf tests
62a054b
@nvnieuwk
fix more workflow tests
300ee2b
@nvnieuwk
set test dir to root of repo
b8fbdce
@nvnieuwk
don't do disk space cleanup anymore
93e956f
Base automatically changed from nf-test-local-modules to dev November 19, 2024 08:55
ToonRosseel
ToonRosseel approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@ToonRosseel ToonRosseel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvnieuwk nvnieuwk merged commit c33262b into dev Nov 19, 2024
32 checks passed
@nvnieuwk nvnieuwk deleted the nf-test-local-subworkflows branch November 19, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToonRosseel ToonRosseel ToonRosseel approved these changes

@matthdsm matthdsm Awaiting requested review from matthdsm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvnieuwk @ToonRosseel