Initial changes required for ZIP64 support #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably not complete and it's not well tested, but it allowed me to open a zip file with version 45 that was using the ZIP64 extension. GitHub-issue: nezticle#1
nezticle
added a commit
that referenced
this pull request
Sep 16, 2015
Initial changes required for ZIP64 support
| if (start == -1) { | ||
| start = readUInt64(data); | ||
| data += 8; | ||
| } |
There was a problem hiding this comment.
Since you just merged this I was reading this code again, and noticed that the above three reads may go beyond the actual size of the data for invalid ZIP archives. Small issue but may be worth adding a check for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably not complete and it's not well tested, but it allowed me to open a zip file with version 45 that was using the ZIP64 extension.
Most importantly, it does not allow reading ZIP files that would actually need this extension. It only makes things work for ZIP files that are using the extension fields for storing the file sizes, but it can't actually handle the higher size limits that are possible this way.
GitHub-issue: #1