Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorials.rst #1083

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tayabsoomro
Copy link

The current instructions for funannotate sort in the tutorial throw the following error:

funannotate sort -i cleaned.fa -b scaffold -o sorted.fa
88 contigs records loaded
Sorting and renaming contig headers
Traceback (most recent call last):
  File "/home/intelliyeast/micromamba/envs/funannotate/bin/funannotate", line 10, in <module>
    sys.exit(main())
  File "/home/intelliyeast/micromamba/envs/funannotate/lib/python3.8/site-packages/funannotate/funannotate.py", line 717, in main
    mod.main(arguments)
  File "/home/intelliyeast/micromamba/envs/funannotate/lib/python3.8/site-packages/funannotate/sort.py", line 80, in main
    SortRenameHeaders(
  File "/home/intelliyeast/micromamba/envs/funannotate/lib/python3.8/site-packages/funannotate/sort.py", line 37, in SortRenameHeaders
    if minlen > 0:
TypeError: '>' not supported between instances of 'NoneType' and 'int'

This is because the minlen variable is not being set currently. Therefore, the current version of the code necessitates--minlen 1 argument.

Add `--minlen 1` to the `funannotate sort` command because otherwise it throws error
@hyphaltip
Copy link
Collaborator

hi so code has already been fixed in the sort routine to default to minlen=0 -- what version are you using of funannotate?

@hyphaltip
Copy link
Collaborator

there's no harm in adding this to the tutorial though.

@tayabsoomro
Copy link
Author

I am using v1.8.17 downloaded from bioconda.

@hyphaltip
Copy link
Collaborator

you can check if /home/intelliyeast/micromamba/envs/funannotate/lib/python3.8/site-packages/funannotate/sort.py looks like https://github.com/nextgenusfs/funannotate/blob/master/funannotate/sort.py

which has minlen=0 in the function initialization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants