fix(FaceRoot#getChild): Validate detection matches cluster

fixes #1073 Signed-off-by: Marcel Klehr <[email protected]>
nextcloud · Jan 9, 2024 · fb26826 · fb26826
1 parent 02f486c
commit fb26826
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/Dav/Faces/FaceRoot.php b/lib/Dav/Faces/FaceRoot.php
@@ -109,6 +109,9 @@ public function getChild($name): FacePhoto {
 		} catch (DoesNotExistException $e) {
 			throw new NotFound();
 		}
+		if ($detection->getClusterId() !== $this->cluster->getId()) {
+			throw new NotFound();
+		}
 		return new FacePhoto($this->detectionMapper, $detection, $this->rootFolder->getUserFolder($this->user->getUID()), $this->tagManager, $this->previewManager);
 	}
 

diff --git a/lib/Db/FaceDetection.php b/lib/Db/FaceDetection.php
@@ -27,7 +27,7 @@
  * @method setHeight(float $height)
  * @method setWidth(float $width)
  * @method setClusterId(int|null $clusterId)
- * @method ?int getClusterId()
+ * @method int|null getClusterId()
  * @method float getThreshold()
  *  @method setThreshold(float $threshold)
  */