-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micro text change: Remove reference to https://github.com/djmoch/nncli #1423
Micro text change: Remove reference to https://github.com/djmoch/nncli #1423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though the repo is archived, it appears the code still works and could be usable for some people. Unless we reference it at https://github.com/nextcloud/notes/wiki#3rd-party-clients too, I don't think we should remove this reference
I'd say this change makes sense. We should not advertise unmaintained projects to prominently. We can still have a reference with a hint that it is no longer maintained in https://github.com/nextcloud/notes/wiki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
I updated the wiki at https://github.com/nextcloud/notes/wiki to mention the unmaintained project instead
40b6878
to
c78353d
Compare
@per-oestergaard Can you please update the commit messages to have the Conventional Commits format so that this CI test passes https://github.com/nextcloud/notes/actions/runs/12607582648/job/35139116282?pr=1423. For example |
Yes, no problem. But I am not sure how I do that as I have never tried that git variant before. Do I have to change the text of both? Or can I create an empty commit with the right format? Or can it be fixed when merging? |
For a single commit, you can use |
Signed-off-by: Per Østergaard <[email protected]>
Signed-off-by: Per Østergaard <[email protected]>
c78353d
to
f2cfebc
Compare
Better now? |
Looks good, thanks. Lets merge this, CI failures are unrelated |
As the repo was archived Jun 18, 2024