Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro text change: Remove reference to https://github.com/djmoch/nncli #1423

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

per-oestergaard
Copy link
Contributor

As the repo was archived Jun 18, 2024

Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the repo is archived, it appears the code still works and could be usable for some people. Unless we reference it at https://github.com/nextcloud/notes/wiki#3rd-party-clients too, I don't think we should remove this reference

@juliusknorr
Copy link
Member

I'd say this change makes sense. We should not advertise unmaintained projects to prominently. We can still have a reference with a hint that it is no longer maintained in https://github.com/nextcloud/notes/wiki

Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

I updated the wiki at https://github.com/nextcloud/notes/wiki to mention the unmaintained project instead

@enjeck enjeck force-pushed the remove-nncli-reference branch from 40b6878 to c78353d Compare January 4, 2025 04:39
@enjeck
Copy link
Contributor

enjeck commented Jan 4, 2025

@per-oestergaard Can you please update the commit messages to have the Conventional Commits format so that this CI test passes https://github.com/nextcloud/notes/actions/runs/12607582648/job/35139116282?pr=1423. For example Remove reference to nncli -> docs: Remove reference to nncli

@per-oestergaard
Copy link
Contributor Author

@per-oestergaard Can you please update the commit messages to have the Conventional Commits format so that this CI test passes https://github.com/nextcloud/notes/actions/runs/12607582648/job/35139116282?pr=1423. For example Remove reference to nncli -> docs: Remove reference to nncli

Yes, no problem. But I am not sure how I do that as I have never tried that git variant before. Do I have to change the text of both? Or can I create an empty commit with the right format? Or can it be fixed when merging?

@juliusknorr
Copy link
Member

For a single commit, you can use git commit --amend to add to your existing commit and change the commit message accordingly. However since you have two the easiest would be to squash them first and then update the commit message using an interactive rebase. Do you want to give that a try? Otherwise we can also do that while merging.

@per-oestergaard
Copy link
Contributor Author

For a single commit, you can use git commit --amend to add to your existing commit and change the commit message accordingly. However since you have two the easiest would be to squash them first and then update the commit message using an interactive rebase. Do you want to give that a try? Otherwise we can also do that while merging.

Better now?

@juliusknorr
Copy link
Member

Looks good, thanks. Lets merge this, CI failures are unrelated

@juliusknorr juliusknorr merged commit 8d05bd1 into nextcloud:main Jan 8, 2025
24 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants