-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:select existing talk room for conversations on calendar events #6595
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6595 +/- ##
============================================
- Coverage 23.41% 23.18% -0.24%
Complexity 472 472
============================================
Files 249 250 +1
Lines 11899 12018 +119
Branches 2269 2308 +39
============================================
Hits 2786 2786
- Misses 8786 8905 +119
Partials 327 327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Changes discussed:
Additional changes:
Follow ups:
|
For reference, the URL for getting conversation avatars is the following: const avatarUrl = generateOcsUrl('apps/spreed/api/v1/room/{roomToken}/avatar', {
roomToken: conversation.token,
}) |
Signed-off-by: greta <[email protected]>
1153693
to
d9749df
Compare
Signed-off-by: greta <[email protected]>
Looks awesome! Could we try with 28px size for the avatar and 34px height of the whole element? I would also suggest to add some spacing between the avatar and the conversation name, maybe one more |
sure
Agreed with nimisha to have it 8px |
Signed-off-by: greta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great design wise 🚀
@nimishavijay what do you think? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Yup, looks good! |
Signed-off-by: greta <[email protected]>
changed the desc with the latest state |
thank you, changed the position as suggested by nimisha. Can you please approve if you are happy with it? |
The button is above the field instead of under it? No opinion on this, but it differs with your previous screenshot. |
yes, she sent me a mockup. Sorry if i was not clear. i marked my comment as outdated |
Signed-off-by: greta <[email protected]>
fixes #6581
This PR adds the ability to link Talk rooms to calendar events. Users can create a new Talk room or select an existing one, and the link is added to the event's location or description(when the location field is already filled).
How to test:
hover state and selected state
the side bar after selecting an existing convesation